[FFmpeg-devel] [PATCH] qcelp: silence handling

[Reynaldo H. Verdejo Pinochet]

Howdy Kenan.

Kenan Gillet wrote:
>
> I am not sure if it should be commited without testing on any
> real sample, but the changes look pretty harmless.

I think we should commit it with some kind of 'experimental support'
warning. maybe asking for samples wouldn't be a bad idea neither.

I will try to take a look at this patch Friday, it looks OK though.

> -            float max_pitch_gain = q->erasure_count < 3 ? 0.9 - 0.3 *
> (q->erasure_count - 1) : 0.0;
> +            float max_pitch_gain;
> +
> +            if (q->erasure_count < 3)
> +                max_pitch_gain = 0.9 - 0.3 * (q->erasure_count - 1);
> +             else
> +                max_pitch_gain = 0.0;
>             for(i=0; i<4; i++)

This particular one is purely cosmetic. Please take it out.

Keep up the good work!

Bests
--
Reynaldo