[FFmpeg-devel] [PATCH] Remove usage of deprecated av_set_string2() in cmdutils.c, ffserver.c and opt.c

[Stefano Sabatini]

On date Thursday 2008-12-18 23:07:16 +0100, Stefano Sabatini encoded:
> On date Thursday 2008-12-18 00:27:42 +0100, Stefano Sabatini encoded:
> [...]
> > I renamed the subject to attract the attention of Baptiste, opt.c and
> > cmdutils.c hunks have been already OKed.
> 
> [...]
> 
> Ping + attached forgotten patch.

All applied.

[...]
> Index: ffmpeg/ffserver.c
> ===================================================================
> --- ffmpeg.orig/ffserver.c	2008-12-16 00:23:11.000000000 +0100
> +++ ffmpeg/ffserver.c	2008-12-16 00:23:17.000000000 +0100
> @@ -3736,8 +3736,8 @@
>                         AVCodecContext *avctx, int type)
>  {
>      int ret = 0;
> -    const AVOption *o2 = av_find_opt(avctx, opt, NULL, type, type);
> -    if(o2)
> +    const AVOption *o = av_find_opt(avctx, opt, NULL, type, type);
> +    if(o)
>          ret = av_set_string3(avctx, opt, arg, 1, NULL);
>      return ret;
>  }

BTW, I wonder if this is the correct behaviour, if the option is not
found then ffserver won't complain, and it won't catch for example a
typo or an old unsupported option.

Regards.
-- 
FFmpeg = Frenzy and Friendly Meaningful Picky Enlightening Ghost