[FFmpeg-devel] [PATCH] Misc patches for libavdevice/v4l.c

[Michael Niedermayer]

On Wed, Dec 24, 2008 at 03:37:05PM +0100, Stefano Sabatini wrote:
> Hi, follows a quick description of the patches:
> 
> * v4l-space-cosmetics.patch: for consistency's sake

ok


[...]

> 
> * v4l-add-missing-ioctl-check.patch: the ioctl may fail

ok


> 
> * v4l-factorize-time-frame.patch: no need to set it in two distinct points

probably ok


> 
> * v4l-remove-unnecessary-temporary.patch: remove the unnecessary
>   frame_size var, write it directly in the context

ok


> 
> * v4l-move-capture-cap-check.patch: this check should be performed before
>   all the other ones

probably ok


[...]


> Index: ffmpeg/libavdevice/v4l.c
> ===================================================================
> --- ffmpeg.orig/libavdevice/v4l.c	2008-12-21 23:45:13.000000000 +0100
> +++ ffmpeg/libavdevice/v4l.c	2008-12-24 13:34:57.000000000 +0100
> @@ -84,11 +84,6 @@
>      }
>      s->time_base = ap->time_base;
>  
> -    if((unsigned)ap->width > 32767 || (unsigned)ap->height > 32767) {
> -        av_log(s1, AV_LOG_ERROR, "Capture size is out of range: %dx%d\n",
> -            ap->width, ap->height);
> -        return -1;
> -    }
>      s->video_win.width = ap->width;
>      s->video_win.height = ap->height;
>  

?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081226/eee5ac7f/attachment.pgp>