[FFmpeg-devel] Patch - Allow disabling of bit reservoir when encoding MP3 audio

[Michael Niedermayer]

On Tue, Feb 05, 2008 at 04:55:51PM +0000, Paul Kelly wrote:
> On Tue, 5 Feb 2008, Michael Niedermayer wrote:
> 
> > On Tue, Feb 05, 2008 at 12:40:18AM +0000, Paul Kelly wrote:
> [...]
> >> Index: libavcodec/utils.c
> >> ===================================================================
> >> --- libavcodec/utils.c	(revision 11865)
> >> +++ libavcodec/utils.c	(working copy)
> >> @@ -762,6 +762,7 @@
> >>  {"non_linear_q", "use non linear quantizer", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_NON_LINEAR_QUANT, INT_MIN, INT_MAX, V|E, "flags2"},
> >>  {"request_channels", "set desired number of audio channels", OFFSET(request_channels), FF_OPT_TYPE_INT, DEFAULT, 0, INT_MAX, A|D},
> >>  {"drc_scale", "percentage of dynamic range compression to apply", OFFSET(drc_scale), FF_OPT_TYPE_FLOAT, 1.0, 0.0, 1.0, A|D},
> >> +{"disable_reservoir", "disable bit reservoir (libmp3lame)", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_DISABLE_RESERVOIR, INT_MIN, INT_MAX, A|E, "flags2"},
> >
> > The mentioning of libmp3lame is not appropriate. The flag is not specific to
> > lame.
> 
> If the mention was removed from there and from the comment against the 
> list of flags in avcodec.h, would the patch be acceptable? I take on board 

Iam not sure if a disable, or enable flag or maybe even a int bit_reservoir
size would be best. Besdides this, yes i would like to have such a thing.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080205/e1e66083/attachment.pgp>