[FFmpeg-devel] [PATCH] Fix ffmpeg crash on G3 based computers introduced with revision 10637

[Michael Niedermayer]

On Sat, Feb 09, 2008 at 12:41:47PM +0000, Patrice Bensoussan wrote:
> 
> On 9 Feb 2008, at 12:22, Reimar D?ffinger wrote:
> 
> > Hello,
> > On Sat, Feb 09, 2008 at 12:11:01PM +0000, Patrice Bensoussan wrote:
> >> It seems that ffmpeg is trying to use altivec on PowerPC G3  
> >> although it's
> >> not available. This was introduced with revision 10637. Here is a  
> >> patch to
> >> fix the issue.
> >>
> >> Patrice
> >>
> >
> >> Index: libavcodec/mpegvideo.c
> >> ===================================================================
> >> --- libavcodec/mpegvideo.c	(revision 11880)
> >> +++ libavcodec/mpegvideo.c	(working copy)
> >> @@ -61,6 +61,10 @@
> >> extern void XVMC_decode_mb(MpegEncContext *s);
> >> #endif
> >>
> >> +#ifdef HAVE_ALTIVEC
> >> +extern int has_altivec(void);
> >> +#endif
> >
> > That #ifdef is pointless.

seconded


> 
> No need to compile code which doesn't need to be. This should only be  
> available if compiling with altivec support.

We dont put #ifdef around comments either.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080209/9e1268fa/attachment.pgp>