[FFmpeg-devel] [PATCH] remove MSVC cruft

Michael Niedermayer michaelni
Tue Feb 12 16:07:39 CET 2008


On Tue, Feb 12, 2008 at 09:11:48AM +0100, Reimar D?ffinger wrote:
> Hello,
> On Tue, Feb 12, 2008 at 01:53:59AM +0100, Michael Niedermayer wrote:
> > #warning no align and asm directives, this might fail
> > #define DECLARE_ALIGNED(n,t,v)      t v
> > #define DECLARE_ASM_CONST(n,t,v)    static const t v
> > #endif
> > 
> > As i suggested would change the default/fallback to normal C. There is nothing
> > in the code that would require a change to configure. Nothing will blow up
> > if HAVE_DECLSPEC is not defined.
> 
> Make it
> #error

absolutely unacceptable, that would make ffmpeg depend on GNU*


> and I do not care, but just #warning for probably generating completely
> broken code is still idiotic IMO.

What broken code? Which non __GNU compiler supports the asm?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080212/d4aa3af5/attachment.pgp>



More information about the ffmpeg-devel mailing list