[FFmpeg-devel] [PATCH] remove MSVC cruft

[Rich Felker]

On Wed, Feb 13, 2008 at 09:56:46AM +0100, Reimar D?ffinger wrote:
> Hello,
> On Tue, Feb 12, 2008 at 08:50:01PM -0500, Rich Felker wrote:
> > On Tue, Feb 12, 2008 at 07:15:22PM +0100, Michael Niedermayer wrote:
> > > > It's two seconds for anyone to fix who knows what they are doing.
> > > 
> > > Why should a user of a plain ISO C (no asm) compiler have to fix anything
> > > when compiling a program which is supposedly ISO C compared to GNU C?
> > 
> > Indeed, this sort of attitude makes me so mad. I spent many hours on
> > such "two second fixes" for countless programs when building them on
> > my system, all due to idiotic GNU assumptions.
> 
> I do not see how assuming that GNU is the only compiler implementing
> asm() is much better, even TurboPascal had an asm thing.

The asm syntax in FFmpeg is GNU syntax and part of "GNU C". If other
compilers (like ICC) support it, it's still "GNU C".

> And for those people it will be more like a two-hour fix to even find
> out what is going wrong...

Huh?

> In addition there seem to be some asms that are not conditional at all.

Surely they're conditional on ARCH_X86 or whatever it's called. If
this is set without checking for the ability to compile GNU C inline
asm, then that's a bug in configure.

> The suggestions here IMO have _not at all_ been about fixing compilation
> with a plain C compiler, but instead about hacking around and pretending
> to do this without considerations to the problems it might cause.

There are no problems it will cause.

Rich