[FFmpeg-devel] [PATCH] WMV3 decoder initialization

[Youness Alaoui]

On Thu, Feb 14, 2008 at 07:28:34PM +0200, Kostya wrote:
> On Wed, Feb 13, 2008 at 02:18:41PM -0500, Youness Alaoui wrote:
> > Hi,
> > 
> > I'm trying to make the WMV3 decoder work for video streaming with aMSN. I wrote a small test app that does that but it kept segfaulting. 
> > Looking at the vc1.c code, I found out that there are some VLC tables that are used without being initialized. You will find attached a patch 
> > that fixes that issue.
> > 
> > p.s: Apparently, some frames make the decoder segfault, so I'll try to fix that.. expect another patch soon. ping me on #ffmpeg if you need 
> > to talk (user : kakaroto*)
> > 
> > Thanks for merging!
> > KaKaRoTo
> 
> Err, that's wrong IMO. I think dependency on
> ff_msmpeg4_decode_init() should be resolved
> in another way.

Yeah, at first, I thought it was the ff_msmpeg4_decode_init tht's not being called correctly, but since I saw that vc1 was also initializing VLC 
tables on its own, I thought that it might be the way to do it. What do you think  move all the VLC init out of vc1 and let ff_msmpeg4_decode_init 
take care of them all ?

KaKaRoTo