[FFmpeg-devel] [patch] allow build env to force sdl-config path via $SDL_CONFIG

[Mike Frysinger]

On Feb 16, 2008 10:03 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, Feb 15, 2008 at 04:09:39PM -0500, Mike Frysinger wrote:
> > On Thu, Feb 14, 2008 at 6:39 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > > On Wed, Feb 13, 2008 at 10:42:43PM -0500, Mike Frysinger wrote:
> > >  > as is standard with pretty much all autotool-based build systems which
> > >  > search for the sdl-config script, this patch allows people to force
> > >  > the full path to sdl-config via the SDL_CONFIG env var.  so now you
> > >  > can do:
> > >  > SDL_CONFIG=/some/crazy/stupid/place/sdl-config ./configure
> > >  > and ffmpeg will find the crazy stupid sdl
> > >  >
> > >  > --- configure (revision 11931)
> > >  > +++ configure (working copy)
> > >  > @@ -1693,7 +1693,7 @@ check_foo_config freetype2 freetype ft2b
> > >  >
> > >  >  disable sdl_too_old
> > >  >  disable sdl
> > >  > -SDL_CONFIG="${cross_prefix}sdl-config"
> > >  > +SDL_CONFIG="${SDL_CONFIG-${cross_prefix}sdl-config}"
> > >                            ^
> > >  This '-' looks wrong.
> > >
> > >  Also, why can't you simply use PATH?
> >
> > the location of the sdl-config wrapper may contain binaries that
> > cannot be executed on the host.  i dont see why there's any objection
> > to the change considering this behavior is perfectly standard for
> > every autotool based package out there that looks for sdl-config.
>
> I still cannot follow you here.  Why don't you set cross_prefix then?

those serve different functions.  the cross_prefix is the toolchain
prefix to locate toolchain and related binaries.  in this case, the
sdl-config script does not have a cross_prefix on it.

i'd also point out that upstream SDL's helper pieces for packages to
build against SDL are designed for two use cases:
${PKG_CONFIG-${cross_prefix}pkg-config} or
${SDL_CONFIG-${cross_prefix}sdl-config}.  in other words, the SDL
maintainers included the SDL_CONFIG variable for people on purpose.
if you're going to emulate the expected behavior, please do it all the
way.
-mike