[FFmpeg-devel] [PATCH] fix build with --disable-encoders

[Michael Niedermayer]

On Fri, Feb 22, 2008 at 02:50:25PM -0500, Alexander Strange wrote:
>
> On Feb 22, 2008, at 2:26 PM, Michael Niedermayer wrote:
>
>> On Fri, Feb 22, 2008 at 01:56:07PM -0500, Alexander Strange wrote:
>>> r12164 added sse2 PNG encoding under CONFIG_ENCODERS, but didn't check it
>>> later on.
>>
>> the code seems to be used in the decoder
>>
>> [...]
>
> So it does.
>

> Index: libavcodec/i386/dsputil_mmx.c
> ===================================================================
> --- libavcodec/i386/dsputil_mmx.c	(revision 12178)
> +++ libavcodec/i386/dsputil_mmx.c	(working copy)
> @@ -1585,6 +1585,8 @@
>      *left    = src2[w-1];
>  }
>  
> +#endif // CONFIG_ENCODERS
> +

Why is there an #ifdef CONFIG_ENCODERS there at all?
Its gccs job to omit unused static functions.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080222/868fe9b1/attachment.pgp>