[FFmpeg-devel] [PATCH] add uuid box to MP4 to make h.264 play on iPod

[Michael Niedermayer]

On Sun, Feb 24, 2008 at 04:41:26PM +0000, Mark Himsley wrote:
> Michael Niedermayer wrote:
>> On Sat, Feb 23, 2008 at 12:14:43PM +0000, Mark Himsley wrote:
>>   
>>> -    else if(track->enc->codec_id == CODEC_ID_H264)
>>> +    else if(track->enc->codec_id == CODEC_ID_H264) {
>>>          mov_write_avcc_tag(pb, track);
>>> +        if(track->mode == MODE_IPOD)
>>> +            mov_write_uuid_tag_ipod(pb);
>>> +    }
>>>     
>>
>> Why is this h.264 specific?
>>   
>
> Because, as I understand it, the uuid tag is only required by Apple for 
> H.264 material.

Remove the h264 check please, unless it breaks other files on the ipod OR
apples own tools omit it as well.


>>> @@ -1454,6 +1472,7 @@
>>>          else if (!strcmp("3g2", s->oformat->name)) mov->mode = MODE_3G2;
>>>          else if (!strcmp("mov", s->oformat->name)) mov->mode = MODE_MOV;
>>>          else if (!strcmp("psp", s->oformat->name)) mov->mode = MODE_PSP;
>>> +        else if (!strcmp("ipod", s->oformat->name)) mov->mode = 
>>> MODE_IPOD;
>>>     
>>
>> Please keep the stuff nicely aligned vertically.
>>
>>   
> Sorry - didn't think I was supposed to submit changes that effected only 
> white space in lines that are not mine.

i meant:

          else if (!strcmp("psp", s->oformat->name)) mov->mode = MODE_PSP;
 +        else if (!strcmp("ipod",s->oformat->name)) mov->mode = 


[...]

> +/* uuid atom to make file play in iPods running newest firmware */
> +/* goes after avcC atom in moov.trak.mdia.minf.stbl.stsd.avc1 */
> +static int mov_write_uuid_tag_ipod(ByteIOContext *pb)
> +{

doxygen compatible comments please


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080224/8a4040f1/attachment.pgp>