[FFmpeg-devel] [VOTE] drop support for using libav* compiled with mingw/cygwin in msvc

[Michael Niedermayer]

On Mon, Feb 25, 2008 at 01:49:42PM -0000, M?ns Rullg?rd wrote:
> 
> Michael Niedermayer wrote:
> > On Mon, Feb 25, 2008 at 01:18:16PM -0000, M?ns Rullg?rd wrote:
> >>
> >> Michael Niedermayer wrote:
> >> > Hi
> >> >
> >> > r12154 has as it seems broken the in the past supported use of
> >> > mingw/cygwin compiled libav* in msvc. Also the change has increased
> >> > code complexity and size.
> >>
> >> Where is this increase in complexity and size?  Stop spreading FUD,
> >> please.
> >
> >
> > svn di -r12153:12154 |diffstat
> >  configure                 |    2 +-
> >  libavcodec/avcodec.h      |    6 ++++--
> >  libavdevice/avdevice.h    |    6 ++++--
> >  libavformat/avformat.h    |    6 ++++--
> >  libavutil/avutil.h        |   12 ++++++++++--
> >  libpostproc/postprocess.h |    6 ++++--
> >  6 files changed, 27 insertions(+), 11 deletions(-)
> >                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> The changed lines are not code, 

Well, code, preprocessor stuff, call it what you want its more now than
there was from it before.


> nor are they significantly complex.

I think everyone understood the original at first sight:

-#define LIBAVUTIL_VERSION_INT   ((49<<16)+(6<<8)+0)
-#define LIBAVUTIL_VERSION       49.6.0


how many understand the following on first sight?

+#define AV_VERSION_INT_3(a, b, c) (a<<16 | b<<8 | c)
+#define AV_VERSION_INT(x) AV_VERSION_INT_3(x)
+
+#define AV_VERSION_3(a, b, c) a ##.## b ##.## c
+#define AV_VERSION(x) AV_VERSION_3(x)
+
+#define LIBAVUTIL_VERSION_TRIPLET 49,6,0
+
+#define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_TRIPLET)
+#define LIBAVUTIL_VERSION       AV_VERSION(LIBAVUTIL_VERSION_TRIPLET)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080225/97d0a0c9/attachment.pgp>