[FFmpeg-devel] [RFC] remove illegal WAV tags

[Diego Biurrun]

On Thu, Feb 28, 2008 at 12:07:46AM +0100, Reimar D?ffinger wrote:
> On Wed, Feb 27, 2008 at 11:55:08PM +0100, Diego Biurrun wrote:
> > I just tried and NUV files seem to work in both ffplay and MPlayer even
> > without this hack.  Is this still needed?  What for?
> 
> You obviously got the wrong NUV file I'd say.

Yes, I had one missing from my samples collection.  The following sample
needs the RAWA fourcc:
http://samples.mplayerhq.hu/nuv/sample.nuv

> I did send a patch that removes them and adds replacement code ages ago though.

I don't remember this patch, where is it?

> > --- libavformat/riff.c	(revision 12270)
> > +++ libavformat/riff.c	(working copy)
> > @@ -213,12 +213,6 @@
> > -
> > -    /* FIXME: All of the IDs below are not 16 bit and thus illegal. */
> > -    // for NuppelVideo (nuv.c)
> > -    { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
> > -    { CODEC_ID_MP3,       MKTAG('L', 'A', 'M', 'E') },
> > -    { CODEC_ID_MP3,       MKTAG('M', 'P', '3', ' ') },
> 
> Also according to git-blame the last entry is for nut, not nuv.

Bug in libnut?

Diego