[FFmpeg-devel] [PATCH] ACT demuxer

[Michael Niedermayer]

On Wed, Feb 27, 2008 at 10:01:20PM +0600, Vladimir Voroshilov wrote:
> Hi, All
> 
> On Mon, Feb 25, 2008 at 11:01 PM, Vladimir Voroshilov
> <voroshil at gmail.com> wrote:
> >  4400 format disabled until sample file of info from disassembled code
> >  will be available.
> >
> 
> Here is updated patch with proper 4400Hz support.
> In this case files contains 22 bytes long frames (first 11-odd bytes,
> second 11-even)
> which forms two subsequent 11 bytes long G.729 frames.
[...]
> +    /*
> +      8000Hz (Fine-rec) file format has 10 bytes long
> +      packets with 10ms of sound data in them
> +
> +      Also exists 4400Hz (Long-rec) file format with
> +      22 bytes long packets of 40ms sound data in them
> +      (each ACT packet forms two 11 bytes long G.729 frames).
> +      But since there is no sample iles, this format is not
> +      yet tested.
> +    */

> +    if (st->codec->sample_rate == 8000) {
> +        st->codec->frame_size=80;
> +    else if (st->codec->sample_rate == 4400) {
> +        st->codec->frame_size=176;
> +    }else
> +        return AVERROR_NOFMT;

There is something wrong with the {}
Also returning 2 G.729 frames in one AVPacket is not ok.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080229/70004411/attachment.pgp>