[FFmpeg-devel] [PATCH] Add default stream flag

[Michael Niedermayer]

On Fri, Feb 29, 2008 at 05:46:59AM +0300, Evgeniy Stepanov wrote:
> On Friday 29 February 2008 04:51:04 Michael Niedermayer wrote:
> [...]
> > > +static void set_disposition_bits(AVFormatContext* avf, char* value,
> > > unsigned int stream_id_plus1){ +    int flag = 0, i;
> > > +    for (i=0; ff_nut_dispositions[i].flag != 0; ++i) {
> >
> > the != 0 is superflous
> >
> >
> > > +        if (!strncmp(ff_nut_dispositions[i].str, value,
> > > +                     strlen(ff_nut_dispositions[i].str))) {
> >
> > why strncmp() and not strcmp() ?
> 
> Mindless copypaste from matroska* )

looks ok (maybe with a minor version bump for the disposition addition to
AVStream)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080229/c87fea54/attachment.pgp>