[FFmpeg-devel] [PATCH] incorrect return type for opt_bitrate/type safety

Rich Felker dalias
Wed Jan 2 02:17:44 CET 2008


On Wed, Jan 02, 2008 at 12:49:09AM +0000, M?ns Rullg?rd wrote:
> >> +    { "L", 0, {func_arg: opt_show_license}, "show license" },
> >> +    { "h", 0, {func_arg: opt_show_help}, "show help" },
> >> +    { "version", 0, {func_arg: opt_show_version}, "show version" },
> >> +    { "formats", 0, {func_arg: opt_show_formats}, "show available formats, codecs, protocols, ..." },
> >> +    { "f", HAS_ARG, {func_arg: opt_format}, "force format", "fmt" },
> >> +    { "i", HAS_ARG, {func_arg: opt_input_file}, "input file name", "filename" },
> >> +    { "y", OPT_BOOL, {int_arg: &file_overwrite}, "overwrite output files" },
> >
> > changing (void*) to the nicer stuff is a cosmetic change and MUST be a 
> > seperate patch
> 
> That syntax is non-standard.  The proper syntax is { .foo = bar }.

Is there any way to get gcc to give warnings (or better errors) for
using obsolete nonstandard gccisms like this?

Rich




More information about the ffmpeg-devel mailing list