[FFmpeg-devel] [PATCH][RFC] TechnoTrend PVA Demuxer

[Ivo]

On Monday 31 December 2007 17:38, Michael Niedermayer wrote:
> On Mon, Dec 31, 2007 at 01:12:31AM +0100, Ivo wrote:
> > I did not however implement seeking yet. That's the RFC. How should I
> > proceed? There's no index. PVA files are encapsulated MPEG-ES (for
> > video) and MPEG-PES (for audio) packets. Should I just rely on the
> > caller (MPlayer, ...) feeding it a new byte-position and resync on the
> > AV-syncword at the start of read_packet() ? And if I do so, can I use
> > url_fseek or does that ruin the ability to pipe the input to ffmpeg?
>
> use av_add_index_entry() every time a packet is demuxed
> and implement read_timestamp()

Ok, I will look into it. It seems that I could use .flags= 
AVFMT_GENERIC_INDEX, for that and don't need any special code inside 
read_packet. And then implement read_timestamp() and perhaps read_seek(). 
But I'll need to RTFS a bit more.

> and feel free to add seeking as a seperate patch if you like

Yes, I will shortly (hopefully :) ).

> > +static int pva_read_close(AVFormatContext *s) {
> > +    return 0;
> > +}
>
> unneeded ...

Removed.

Patch comitted.

--Ivo