[FFmpeg-devel] Headers moving?

[Michael Niedermayer]

On Sat, Jan 05, 2008 at 12:12:42AM +0100, Aurelien Jacobs wrote:
> On Fri, 4 Jan 2008 12:03:15 +0100
> Michael Niedermayer <michaelni at gmx.at> wrote:
[...]
> 
> > [...]
> > > +#ifndef CONFIG_HARDCODED_TABLES
> > > +    if (!av_crc_table_params[crc_id].inited) {
> > > +        if (av_crc_init(av_crc_table[crc_id],
> > > +                        av_crc_table_params[crc_id].le,
> > > +                        av_crc_table_params[crc_id].bits,
> > > +                        av_crc_table_params[crc_id].poly,
> > > +                        sizeof(av_crc_table[crc_id])) < 0)
> > > +            return NULL;
> > > +        av_crc_table_params[crc_id].inited = 1;
> > > +    }
> > 
> > i agree the inited is cleaner but 
> > av_crc_table[crc_id][257] and av_crc_table[crc_id][1024]
> 
> I guess you meant:
> av_crc_table[crc_id][256] and av_crc_table[crc_id][1023]
> :-)
> 
> > will work as well and need an instruction less
> 
> Right. Done.
> 
> Applied with suggested changes.
> 
> Now I guess I can commit original patch (installing crc.h) ?

installing crc.h is ok yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080105/bae9ee30/attachment.pgp>