[FFmpeg-devel] [PATCH] Automatically generate ac3enc_data.h

[Michael Niedermayer]

On Sat, Jan 12, 2008 at 06:00:08PM +0100, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> 
> > On Sat, Jan 12, 2008 at 05:31:00PM +0100, Aurelien Jacobs wrote:
> > > Diego 'Flameeyes' Petten? wrote:
> > > 
> > > > 
> > > > It's not the nicest thing out there, but it should work...
> > > > 
> > > > [...]
> > > > 
> > > > +%-gentables: %_tables.c
> > > > +	$(CC) $(CFLAGS) -DGENTABLES -o $@ $^ $(EXTRALIBS)
> > > 
> > > $(CC) is the TARGET compiler. You can't use it to compile binary
> > > that must be run on HOST. (you cross-compiling...)
> > > 
> > 
> > > Now that I think about it, it could be better to keep the
> > > ac3enc_data.h file in the repository, 
> > 
> > hmm, i cant explain it but i dont like this idea
> 
> Having an explanation would be nice, but well...

it reminds me of generated auto* shit commited to cvs/svn ...
also if they are in svn that means more bandwidth for checkouts, larger
snapshots, ...

and people changing th generator code (and using runtime generated tables)
could easily forget tp check the new tables in
then theres the issue that with float tables they could differ between
systems, which could actually make checking in a changed table less easy
as unrelated tables in the same file might have changed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080112/9108391b/attachment.pgp>