[FFmpeg-devel] [PATCH] check if bsf returns an error in ffmpeg.c

Benoit Fouet benoit.fouet
Fri Jan 18 12:31:15 CET 2008


Michael Niedermayer wrote:
> On Fri, Jan 18, 2008 at 12:05:48PM +0100, Benoit Fouet wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> On Tue, Jan 15, 2008 at 05:49:21PM +0100, Benoit Fouet wrote:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> attached is a patch to $subj
>>>>     
>>>>         
>>> silently muxing broken data is not good
>>>
>>>   
>>>       
>> do you mean this should be done (muxing) with a message or not done at all ?
>> if the bitstream filter returns an error, it shouldn't have touched the
>> data IMHO, so we would mux input data unchanged
>> (I'll have to have a look at current bitstream filters to know what they
>> do, though)
>>     
>
> I think mux with error message ...
>
>   

something like the attached patch then ?
(i was wondering whether we should output the message only once or not...)

-- 
Ben
Purple Labs S.A.
www.purplelabs.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080118/24619d1b/attachment.asc>



More information about the ffmpeg-devel mailing list