[FFmpeg-devel] [RFC] replace some static with asm_visibility or so

[Reimar Döffinger]

Hello,
On Sun, Jan 27, 2008 at 03:10:39PM +0100, Reimar D?ffinger wrote:
> as you may know current code does not compile with ICC and assembler due
> to it optimizing away all the constants.
> I wonder if you'd find it acceptable to replace all the "static"
> attributes by a define, e.g. "asm_visibility" that would be static by
> default but empty for any compilers that cannot handle it (actually, I'd
> be just happy with having it defined to static always, a one line change
> seems ok to me to compile with a different compiler, just not the
> current situation).

On second though, something like
#define DECLARE_ASM_CONST(n,t,v) static const t v attribute_used __attribute__ ((aligned (n)))
might work out nicer (less clutter).
Also makes sure nobody uses something global, non-const from asm code without
thinking.
Opinions, alternatives?

Greetings,
Reimar D?ffinger