[FFmpeg-devel] [PATCH] Add versioning information to dlls

[Måns Rullgård]

Jeremy Kolb <jkolb at wsi.com> writes:

> Diego Biurrun wrote:
>> On Tue, Jul 01, 2008 at 02:19:54PM +0100, M?ns Rullg?rd wrote:
>>
>>> Diego Biurrun wrote:
>>>
>>>> On Tue, Jul 01, 2008 at 11:30:33AM +0100, M?ns Rullg?rd wrote:
>>>>
>>>>> Diego Biurrun wrote:
>>>>>
>>>>>> On Mon, Jun 30, 2008 at 11:35:50AM -0400, Jeremy Kolb wrote:
>>>>>>
>>>>>>> --- configure	(revision 14033)
>>>>>>> +++ configure	(working copy)
>>>>>>> @@ -970,6 +970,7 @@
>>>>>>>
>>>>>>>  # gcc stupidly only outputs the basename of targets with -MM
>>>>>>>  DEPEND_CMD='$(CC) $(CFLAGS) -MM -MG $< | sed -e "/^\#.*/d" -e
>>>>>>> "1s,^,$(@D)/," -e
>>>>>>> "s,\\([[:space:]]\\)\\(version\\.h\\),\\1\$$(BUILD_ROOT_REL)/\\2," -e
>>>>>>> "s/\(.*\)\.o/\1.d &/"'
>>>>>>> +DEPEND_CMDRC='$(CC) $(CFLAGS) -MM -MG -DRC_INVOKED -xc-header $< | sed -e "/^\#.*/d" -e "1s,^,$(@D)/,"'
>>>>>>>
>>>>>> Why are you skipping the rest of the sed commands?  What is the output
>>>>>> or DEPEND_CMDRC?
>>>>>>
>>>>> Rather than another variable, just add the extra flags in the make rule.
>>>>>
>>>> How?
>>>>
>>> %.d: %.rc CFLAGS += -DRC_INVOKED -xc-header
>>> 	$(DEPEND_CMD) > $@
>>>
>>> This construct is already used elsewhere in the makefiles.
>>>
>>
>> And I have used it many times myself :)  So this should have been pretty
>> obvious.
>>
>> Diego
>>
>>
> Ok here's the updated patch.

Is it OK if we delay this stuff a little?  I have some changes in mind
for how version information is handled in general.  I'd like to have
all the version related stuff driven from makefiles rather than
configure, to make sure version changes are reflected in the build,
even if configure isn't run.  This would also make integrating this
dll version functionality nicer.

I'm currently busy trying to get an FFmpeg demo running on a
Beagleboard (TI OMAP3530, ARM Cortex-A8) by the 19th, so I won't have
much time to work on the build system before that.

-- 
M?ns Rullg?rd
mans at mansr.com