[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

[Diego Biurrun]

On Mon, Jun 30, 2008 at 11:34:41PM +0200, Michael Niedermayer wrote:
> On Mon, Jun 30, 2008 at 10:55:53PM +0200, Reinhard Tartler wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > > The question is, do we have someone who is willing and able to maintain
> > > it? One who will fix bugs reported by users in case there are any ...
> > > So far people just said they want the patch, also at least one said
> > > that he wouldnt be able to maintain it. I do not remember anyone
> > > volunteering to maintain this patch ...
> > 
> > What qualification would that person need?
> 
> able to code in C, review C code use a debugger, compiler and editor and be
> smart enough to debug possibly non trivial bugs in a C program.
> With some luck the patch is fine but if not there could be various obscure
> issues
> IIRC some issue was actually already found and fixed in some variant used
> by some distro in this thread ...

My patch is better than just adding '#if 0' in some places, which is
what some distros did.

> > AFAIUI Diego seems to be willing to support it as he proposed it in the
> > beginning of this thread. I'm willing to assist him with that from the
> > distro POV.
> > 
> > >> Distros are carrying this patch for years now without serious
> > >> concerns, after all, so it cannot be that broken as one might suspect
> > >> in the first place.
> > >
> > > Distros are carrying alot for years ...
> > >
> > > My general rule of thumb is nowadays, if something doesnt work and its not
> > > obviously my own fault, it tends to be the vendors fault more often than
> > > upstreams ...
> > 
> > That's why this patch was forwarded to upstream in the first place: In
> > the hope to get commented properly. Up to know the only answer I got
> > was "naah, go away, we don't know what effects this might have and don't
> > care enough to look at it". :/ [1]
> 
> If we have someone willing to maintain then his first job is to properly
> review the patch take a quick look at old and new stuff and declare if its
> ok or not (and if not then why not) ...

Somehow I fail to see what exactly the problem with my patch is.  Right
now we *do* have a problem.  The problem is in our code, not in some
distro tree.  We have a buggy mix of conditionals.  Some parts of the
code depend on lavc version, others on libswscale.  This cannot be
right.

I have a feeling that you are going off on a tangent.  What exactly is
the problem with my patch?

Diego