[FFmpeg-devel] [PATCH] AAC Decoder round 3

[Robert Swain]

2008/7/7 M?ns Rullg?rd <mans at mansr.com>:
> Michael Niedermayer <michaelni at gmx.at> writes:
>
>> On Mon, Jul 07, 2008 at 02:50:36AM +0100, Robert Swain wrote:
>>> 2008/7/6 Michael Niedermayer <michaelni at gmx.at>:
>>> > On Tue, Jul 01, 2008 at 12:37:11PM +0100, Robert Swain wrote:
>>> > [...]
>>> >> +/**
>>> >> + * Free a channel element.
>>> >> + */
>>> >> +static void che_freep(ChannelElement **s) {
>>> >> +    if(!*s)
>>> >> +        return;
>>> >> +    av_freep(s);
>>> >> +}
>>> >
>>> > am i too tired or is the if-return useless and this a senseless wraper
>>> > function?
>>>
>>> I'll remove it for the next submission but it's needed for SSR/LTP in
>>> SoC so I won't remove it there.
>>
>> Its needed to check p == NULL before av_free(p) ?

I meant I'd remove the entire wrapper and just use av_freep().

> No.

The SoC code for LTP and SSR uses av_free() so I guess the check is needed.

Anyway, fixed.

Rob