[FFmpeg-devel] [PATCH] use bytestream functions more in adpcm.c

Reimar Döffinger Reimar.Doeffinger
Sat Jul 12 14:18:02 CEST 2008


Hello,
On Sat, Jul 12, 2008 at 12:40:44PM +0100, Ramiro Polla wrote:
> I think these look better if vertically aligned.

Done locally.

> I looked at this file yesterday and thought about these same changes 
> (but was too lazy to actually do them).
> 
> The file has lots of code that would be more readable if vertically 
> aligned. I also thought about moving the cases inside the huge switches 
> in decode/encode frame into their own functions, so that they can easily 
> be #ifdef'd out undef CONFIG_ADPCM_BLAH.

Yes, there is a lot of work and probably a few cosmetics to be done for
the code to be really nice, and there are unfortunately also several
real bugs, but I tend to make enough errors even when I do things on
step at a time.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list