[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (3/4) acelp_vectors

The Wanderer inverseparadox
Sat Jul 12 16:28:32 CEST 2008


Diego Biurrun wrote:

> On Sat, Jul 12, 2008 at 04:03:48PM +0700, Vladimir Voroshilov wrote:
> 
>> 2008/7/12 Diego Biurrun <diego at biurrun.de>:

>>> Sure? :)
>> 
>> Hm. I was sure :)
>> 
>> --- a/libavcodec/acelp_vectors.h
>> +++ b/libavcodec/acelp_vectors.h
>> @@ -126,6 +126,34 @@ void ff_acelp_fc_pulse_per_track(
>>  
>> + * First and second pulse signs are the same if first index is less or equal
>> + * to second and opposite - otherwise
> 
> I would suggest
> 
> The first and second pulse signs are the same if the first index is
> less than or equal to the second and opposite index
> 
> assuming that I understood what you wanted to say.
> 
>> + * to second and opposite - otherwise
> 
> Otherwise what?

I think this meant "If the first index is less than or equal to the
second, then the first and second pulse signs are the same; otherwise,
the signs are opposite one another". I wouldn't phrase it that way in
the actual comment, but I believe that's what was meant.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.




More information about the ffmpeg-devel mailing list