[FFmpeg-devel] [PATCH] Compute absolute paths in configure

[Stefano Sabatini]

On date Friday 2008-07-11 14:40:30 +0100, M?ns Rullg?rd encoded:
> 
> Stefano Sabatini wrote:
> > On date Friday 2008-07-11 12:02:36 +0100, M?ns Rullg?rd encoded:
> >>
> >> Stefano Sabatini wrote:
> >> > Hi all,
> >> >
> >> > if you set for example a prefix like this:
> >> > configure --prefix=../..
> >>
> >> Then you either have a good reason to do so, or you can blame yourself.
> >>
> >> > then you'll find the relative path for example in the pkg-config
> >> > files, which doesn't work properly.
> >> >
> >> > This patch make configure compute the absolute path of every path set
> >> > by configure (yes maybe it needs to be splitted also for what regards
> >> > the PATHS_LIST part).
> >>
> >> Are yo sure about that?  Why are you messing with cross_prefix?
> >>
> >> > I'm not sure if this is correct though, maybe there are cases where
> >> > there is the need to keep relative paths (but this doesn't work for
> >> > sure with pkg-config paths, which need to be absolute), in those cases
> >> > the user is forced to specify absolute paths.
> >>
> >> We should use whatever the user specifies.  There is nothing more
> >> annoying than tools trying to be too clever.
> >
> > Yes, anyway relative paths seem OK everywhere but when you set them in
> > the various pkg-config file.
> >
> > The attached patch fixes the problem in a maybe slightly less invasive
> > way than the previous one.
> >
> > BTW, this doesn't work if the prefix as specified by the user doesn't
> > exist, maybe we should add a check for that.
> 
> If the prefix doesn't exist, make install will create it.  Breaking this
> is not acceptable.

Yes this objection is a patch-killer, a possible but awkward
solution could be to implement a function which computes the absolute
path of a relative path without to actually require to cd to that dir,
but I'm not sure if that's worth the effort...

Regards.
-- 
FFmpeg = Forgiving and Faboulous Magical Prodigious Easy Guru