[FFmpeg-devel] [RFC/PATCH] More flexible variafloat_to_int16 , WMA optimization, Vorbis

[Michael Niedermayer]

On Tue, Jul 15, 2008 at 01:57:33AM -0600, Loren Merritt wrote:
> On Tue, 15 Jul 2008, Siarhei Siamashka wrote:
>>
>> Regarding, "float_to_int16_interleave" function, it would be nice to also
>> add at least "stride" argument in addition to "len". That would make it 
>> usable
>> for WMA. And it could be still possibly useful for vorbis (with some 
>> changes
>> to code, stride might become needed).
>
> like this? (wma part not really tested)

May i suggest an array of src pointers instead of stride?
Reason is, if we want to use this function in the future in a generic
converter stride will not be enough because we likely will have a
array of source pointers from the user.
Besides it would allow reordering channels.

It also might be worth to look at mplayer/liba52/resample_mmx.c, maybe some
of that code could be reused. Especially as we do not have a MMX
float_to_int16, besides the trick used could be tried with SSE2.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080715/3eea4333/attachment.pgp>