[FFmpeg-devel] libraries linked with libX11 on GNU/kFreeBSD

[Diego Biurrun]

On Wed, Jul 16, 2008 at 03:35:33PM +0100, M?ns Rullg?rd wrote:
> 
> Reinhard Tartler wrote:
> >
> > ffmpeg-free links with -Wl,--as-needed on GNU/Linux, so the resulting
> > libraries are not linked with libX11. This is something required by VLC.
> > On GNU/kFreeBSD, -Wl,--as-needed is not used, so VLC fails to build.
> > Please find below a patch to fix that.
> >
> > --- ffmpeg-free-0.svn20080206.orig/configure
> > +++ ffmpeg-free-0.svn20080206/configure
> > @@ -1289,6 +1289,9 @@
> >          ;;
> > +    gnu/kfreebsd)
> > +        LDLATEFLAGS="-Wl,--as-needed $LDLATEFLAGS"
> > +        ;;
> >
> >      *)
> >          targetos="${targetos}-UNKNOWN"
> 
> The use of this flag should depend on the linker, not the OS.  If
> existing code sets this based on OS, that code is wrong and should
> be fixed.  Patches adding incorrect code are rejected, regardless
> of what already exists.

Well, it's not really Reinhard's job to clean up the more obscure parts
of configure.  The LDLATEFLAGS hack was added to work around some linker
issues, if my hazy memory serves me right.  I remember that we both
wondered about the reasons for this on IRC.  Luca might remember we he
added this in the first place...

Anyway, patch looks OK to me, cleaning up LDLATEFLAGS is outside of the
scope of adding gnu/kfreebsd support.

Diego