[FFmpeg-devel] [PATCH] fix libswscale+altivec+-std=gnu99 compile

[compn]

On Thu, 17 Jul 2008 01:21:29 +0200, Diego Biurrun wrote:
>On Wed, Jul 16, 2008 at 02:05:36PM -0400, compn wrote:
>> On Wed, 16 Jul 2008 19:35:05 +0200, Michael Niedermayer wrote:
>> >On Wed, Jul 16, 2008 at 12:30:42PM -0500, compn wrote:
>> >> On Sun, 13 Jul 2008 18:29:00 -0400, Alexander Strange wrote:
>> >> >
>> >> >On Jul 13, 2008, at 6:05 PM, Diego Biurrun wrote:
>> >> >
>> >> >> On Sun, Jul 13, 2008 at 05:13:49PM -0400, Alexander Strange wrote:
>> >> >>> See subject. I tested it via cross-compile.
>> >> >>
>> >> >> I committed something similar for two files in libavcodec/ppc with
>> >> >> Luca's blessing, so I expect this to be OK as well.
>> >> >
>> >> >Applied.
>> >> 
>> >> is this a new problem?
>> >
>> >did it work before the gnu99 fixes?
>> 
>> yes, reverting to 14128 on libavcodec/ppc/fdct_altivec.c
>> and 27190 on libswscale/yuv2rgb_altivec.c works.
>
>I just fired up OS X 10.4.11 on my PowerBook to verify this.  I get a
>compilation failure with gcc 3.3, but everything works fine with gcc
>4.0.  Since gcc 4.x is far superior on PowerPC, I do not think this is a
>problem.

some would say gcc 4.x is far superior to 2.9.5 ... a slippery slope indeed.

-compn