[FFmpeg-devel] libraries linked with libX11 on GNU/kFreeBSD

[Måns Rullgård]

Reinhard Tartler wrote:
> Diego Biurrun <diego at biurrun.de> writes:
>
>> On Thu, Jul 17, 2008 at 07:59:46AM +0200, Reinhard Tartler wrote:
>>> M?ns Rullg?rd <mans at mansr.com> writes:
>>>
>>> >> Anyway, patch looks OK to me, cleaning up LDLATEFLAGS is outside of the
>>> >> scope of adding gnu/kfreebsd support.
>>> >
>>> > I stand by my rejection of the patch.  The existing code is wrong.  We
>>> > should fix it properly instead of adding more broken code.
>>>
>>> Okay, no problem. I'll carry then this patch in the debian/ubuntu
>>> package until the code in question gets replaced upstream then. And to
>>> be honest, I doubt that someone outside Debian actually cares about
>>> gnu/kfreebsd.
>>
>> An even better procedure would be to propose the patch before applying
>> it to your package and then try to find a clean solution in cooperation
>> with your upstream (us).  You could then backport such a solution to
>> your package.
>
> Yes, I agree that this is a good idea to do in general.  However for
> this particular issue, this particular patch is pretty trivial and does
> affect only a very small number of machines. Here, it affects only
> gnu/kfreebsd machines.  For more complicated patches, I'd of course
> prefer to have it commented by some more experienced developer before
> publishing it anywhere.

One word: OpenSSL.

-- 
M?ns Rullg?rd
mans at mansr.com