[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

[Baptiste Coudurier]

Hi Luca,

Luca Abeni wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> [...]
>>>> Iam not sure if its the best either ... maybe we should change
>>>> ff_avc_parse_nal_units to take a ByteIOContext ...
>>>> Of course only if it would end up simpler, if its not simpler than
>>>> your patch here is ok
>>> Ok; this afternoon I'll try to have a look at passing a ByteIOContext
>>> as an
>>> argument (but first I have to understand why this can simplify things
>>> ;-).
>>
>> writing straight vs. writing into a buffer, checking that something was
>> written and then put_buffer it ...
> 
> Ok; I was looking at the wrong place ;-) (I started by looking at the
> impact
> of this change on ff_isom_write_avcc()).
> 
> I now see how your idea can simplify the code. Unfortunately, I got
> sidetracked by some other issues, and I've not been able to test these
> changes. I attach a patch, to show how the final result will look like,
> but be aware that the patch is only compile-tested.
> I am not sure I like the way I changed ff_isom_write_avcc()... I'll have
> to think about it a little bit more.
> 
> I'll probably have a tested patch next week.
> 
> [...]
> 

Well at first sight, I'd say first patch not using ByteIOContext is simpler.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA