[FFmpeg-devel] [PATCH] GET_RL_VLC can hide function parameters

[Reimar Döffinger]

On Tue, Jul 22, 2008 at 09:10:22AM -0700, Erik Hovland wrote:
> On Tue, Jul 22, 2008 at 04:24:49PM +0100, M?ns Rullg?rd wrote:
> > >> Wouldn't it be better to change the GET_RL_VLC macro to use names less
> > >> likely to clash?
> > >
> > > That is what the patch does. Is length too common as well?
> > 
> > I'd be inclined to say yes.
> 
> Patch resubmitted with n changed to vlc_length.

If the goal is to avoid clashes, this kind of change is simply
pointless, and also doing it only to one variable is not that
helpful.
_If_ we want a proper fix for this, something like prefixing everything
with e.g. get_rl_vlc_ or shorter grv_ should be quite reliable, but
uglify the code.
If a proper fix is not wanted, then the question is what we would
want...

Greetings,
Reimar D?ffinger