[FFmpeg-devel] [PATCH] AAC Decoder round 4

[Robert Swain]

2008/7/22 Diego Biurrun <diego at biurrun.de>:
> On Tue, Jul 22, 2008 at 02:47:30PM +0200, Michael Niedermayer wrote:
>> On Tue, Jul 22, 2008 at 12:39:28PM +0100, Robert Swain wrote:
>> > 2008/7/18 Robert Swain <robert.swain at gmail.com>:
>> > > 2008/7/18 Robert Swain <robert.swain at gmail.com>:
>> > >> 2008/7/14 Robert Swain <robert.swain at gmail.com>:
>> > >>> 2008/7/10 Robert Swain <robert.swain at gmail.com>:
>> > >>>> $subj
>> > >>>
>> > >>> In light of the ff_imdct_half(), float_to_int16_interleave() and
>> > >>> related functions, I will be altering those sections of the code. I'll
>> > >>> resubmit when I've made these changes but the rest of the code should
>> > >>> remain the same.
>> > >>
>> > >> float_to_int16_interleave() is done. imdct_half() is still in progress
>> > >> as there's a bug in the code I've written. I don't think this should
>> > >> be a stopper for this getting into trunk though
>> > >
>> > > By this I mean that I will provide a patch for conversion to
>> > > imdct_half and vector_fmul_window later when I've got it working. The
>> > > old style fmul_add_add is still used for the moment but isn't buggy.
>> >
>> > Ping? Little has changed in the patch from the original submission
>>
>> Its a 174k patch, reviewing such large patches takes time and is not fun.
>
> Maybe the tables can be split out or something?  That should reduce the
> size considerably...

I make it 131307 bytes and splitting the tables isn't really worth the
effort. I don't think it would accelerate the review process at all.

Rob