[FFmpeg-devel] [PATCH] avoid infinite loop when seeking flv and non seekable input

[Michael Niedermayer]

On Tue, Jul 22, 2008 at 07:41:51PM -0700, Baptiste Coudurier wrote:
> Hi,
> 
> $subject,
> 
> Reproduceable when trying to seek and input is non seekable (like http
> through ffserver).
> 
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2705408, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2763520, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2818048, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2856192, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2889728, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 0, size 11469089, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2949120, flags 0
> [flv @ 0x8e27eb0]skipping flv packet: type 32, size 2987264, flags 0
> 
> With patch resync happens faster:

I dont understand the problem, "trying to seek and input is non seekable"
makes no sense to me. If the input is unseekable, seeking wont succeed
anyway.
Besides i do not understand why the attempt leads to any desyc in the first
place. Whatever causes the desyc in the first place likely is buggy.

Of course besides this, flvdec.c can be improved to be more resistant
against errors and to resync faster that would require first to detect
the desync (easy as the previous patcket size is stored in the header).
...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080723/49252a04/attachment.pgp>