[FFmpeg-devel] [PATCH] AAC Decoder round 4

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Jul 27, 2008 at 04:04:29AM +0200, Michael Niedermayer wrote:
>> On Fri, Jul 18, 2008 at 03:13:38PM +0100, Robert Swain wrote:
>> > 2008/7/14 Robert Swain <robert.swain at gmail.com>:
>> > > 2008/7/10 Robert Swain <robert.swain at gmail.com>:
>> > >> $subj
>> > >
>> > > In light of the ff_imdct_half(), float_to_int16_interleave() and
>> > > related functions, I will be altering those sections of the code. I'll
>> > > resubmit when I've made these changes but the rest of the code should
>> > > remain the same.
>> > 
>> > float_to_int16_interleave() is done. imdct_half() is still in progress
>> > as there's a bug in the code I've written. I don't think this should
>> > be a stopper for this getting into trunk though and I will mark myself
>> > as maintainer of aac.c and aactab.h when it's there.
>> > 
>> > Attached is a new full patch that is synced with the changes made
>> > since the earlier patch in this thread.
>> > 
>> > Michael: Ping? :)
>> 
>> yes yes ...
>> lets try a slightly modified review process due to the size of the patch.
>> The parts (and only them) that are marked with ok should be commited, so i
>> do not have to review them again / and you dont have to send them again.
>
>> (no the result doesnt has to compile)
>
> Just to clarify before the trolls wake up, ffmpeg has to compile, the newly
> added files which would not be referenced by any makefile dont have to.

The trolls should be fine with that.

-- 
M?ns Rullg?rd
mans at mansr.com