[FFmpeg-devel] [PATCH] split-radix FFT

[Michael Niedermayer]

On Tue, Jul 29, 2008 at 07:36:06AM -0600, Loren Merritt wrote:
> On Tue, 29 Jul 2008, Michael Niedermayer wrote:
> >
> > Also if i use MANGLE to access the 2 root2 globals things clear up a bit in
> > the code generated, so i would suggest that to be done at least, even if
> > the asm stays split up.
> 
> If we don't actually require the output to be position independent, isn't 
> the simpler solution to not compile with -fPIC? Or are we doing some sort 
> of informed trade-off where only the most cpu-intensive functions get 
> textrels?

Thats a good argument as well. Though i was more thinking of distributions
that have a policy that says -fPIC must be added to the flags.

http://www.debian.org/doc/debian-policy/ch-files.html:
10.2 Libraries

If the package is architecture: any, then the shared library compilation and linking flags must have -fPIC, or the package shall not build on some of the supported architectures[60]. Any exception to this rule must be discussed on the mailing list debian-devel at lists.debian.org, and a rough consensus obtained. The reasons for not compiling with -fPIC flag must be recorded in the file README.Debian, and care must be taken to either restrict the architecture or arrange for -fPIC to be used on architectures where it is required.
-----


> On a related note, does this mean that when I commit yasm stuff, 
> I shouldn't bother to support PIC on x86_32?

yes, if it works (with textrels) and -fpic


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080729/07e2e028/attachment.pgp>