[FFmpeg-devel] [PATCH] split-radix FFT

[Uoti Urpala]

On Tue, 2008-07-29 at 17:32 +0200, Michael Niedermayer wrote:
> On Tue, Jul 29, 2008 at 06:18:19PM +0300, Uoti Urpala wrote:
> > On Tue, 2008-07-29 at 16:46 +0200, Michael Niedermayer wrote:
> > > You argued in favor of using MANGLE ?
> > 
> > Against using it. The argument being that if you don't want PIC, don't
> > compile with -fPIC (the asm files at least) instead of using -fPIC and
> 
> The argument to which i replied is not choosen by you after my reply!

You snipped the part where I explicitly questioned what you were
originally replying to (to me it looked like Loren's original question
really was a question, not an argument) and then reply to another part
of my message claiming that I "chose what argument you replied to". If
the meaning of your original reply is the only issue you're addressing
then at least reply to the part of my message which talks about it (and
don't claim I "chose what you replied to" when I explicitly address the
uncertainty of what you were talking about).

> > > > >  Though i was more thinking of distributions
> > > > > that have a policy that says -fPIC must be added to the flags.
> > > > > 
> > > > > http://www.debian.org/doc/debian-policy/ch-files.html:
> > > > > 10.2 Libraries
> > > > 
> > > > Currently FFmpeg in Debian is built without -fPIC on x86.
> > > 
> > > Iam happy to hear this, still the point stands, distributions have such
> > > requirements. And it takes the package maintainer quite a bit of work (or
> > > rulebreaking) to not compile with -fpic.
> > 
> > And how does using MANGLE improve things? 
> 
> It makes the code run faster and makes it smaller, but i said that already.

As would just omitting -fPIC, without the ugliness of MANGLE. But my
question was about the distribution case. I'll rephrase it if if the
original wasn't clear enough:
You said that MANGLE helps with distributions that have a policy that
requires using -fPIC. How does it actually help? It just creates
textrels with a different (and uglier) method. Is the benefit that it's
easier to break the policy without anyone noticing (there's a -fPIC on
the command line... it's just using another method to negate it). Or do
you think that someone will count the textrels and say "well breaking
the policy by this amount of textrels from the asm is ok, even though a
larger number from the C parts wouldn't be"?