[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

[Robert Swain]

On 4 Jun 2008, at 21:56, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
>> On Wed, Jun 04, 2008 at 11:18:46AM -0700, Baptiste Coudurier wrote:
>>> Michael Niedermayer wrote:
>>>> On Wed, Jun 04, 2008 at 08:09:02AM -0600, Jason Garrett-Glaser  
>>>> wrote:
>>>>>> Id just tell users to use FULL if they mean FULL ...
>>>>> IMO for consistency with other x264 options "esa" should be  
>>>>> available,
>>>>> but it should just be an alias for full.  Takes minimal code and  
>>>>> makes
>>>> ok
>>>>
>>>> but IMHO ESA is not a logic abbreviation for full search, just me  
>>>> 2 cent
>>>>
>>>>
>>>>> the interface that little bit more user friendly, something that  
>>>>> is
>>>>> sorely needed with x264 encoding under ffmpeg.
>>>> People prefer complaining about problems than working on  
>>>> solutions ...
>>>>
>>> Well I do work on solutions :>
>>
>> Me too, ive a half finished per codec defaults change locally ...
>
> Awesome !

I made some patches for this that didn't quite work that used the  
'wrong' approach. Baptiste said they should use AVOption instead but I  
was unaware of this API at the time and by the time I'd finished  
writing it only to be told it would need rewriting, I didn't have the  
motivation to fix it up. :)

If you want to look at what I did, they are patches 0001-0004* here:

http://www.swains.plus.com/superdump/ffmpeg/patches/

I would appreciate if you made what you've done available too as I may  
have some criticisms! :)

Rob