[FFmpeg-devel] [PATCH] add ME_T/ESA to avcodec.h

[Baptiste Coudurier]

Hi guys,

Michael Niedermayer wrote:
> On Thu, Jun 05, 2008 at 09:42:06AM +0100, Robert Swain wrote:
>> 2008/6/5 Michael Niedermayer <michaelni at gmx.at>:
>>> On Wed, Jun 04, 2008 at 11:55:23PM +0100, Robert Swain wrote:
>>>> On 4 Jun 2008, at 21:56, Baptiste Coudurier wrote:
>>>>> Michael Niedermayer wrote:
>>>>>> Me too, ive a half finished per codec defaults change locally ...
>>>>> Awesome !
>>>> I made some patches for this that didn't quite work that used the
>>>> 'wrong' approach. Baptiste said they should use AVOption instead but I
>>>> was unaware of this API at the time and by the time I'd finished
>>>> writing it only to be told it would need rewriting, I didn't have the
>>>> motivation to fix it up. :)
>>>>
>>>> If you want to look at what I did, they are patches 0001-0004* here:
>>>>
>>>> http://www.swains.plus.com/superdump/ffmpeg/patches/
>>>>
>>>> I would appreciate if you made what you've done available too as I may
>>>> have some criticisms! :)
>>> Code below,
>>> just put -vpre anime-hq on the command line and have a file with the path
>>> ~/.ffmpeg/mpeg4-anime-hq.ffpreset
>>> with all your AVOptoion key=value stuff in it
>>> similar for other codecs.
>>>
>>> minor known bug, -vpre must be after -vcodec
>>>
>>> Iam planning to commit the code if there are no objections ...
>> This is presets code, not per codec defaults, but it's good. :)
> 
> Well, defaults are one preset IMHO
> It would be easy just to do the equivalent of '-vpre default' when no
> other -vpre is specified.
> I suspect that would be much simpler than your code, also defaults would
> be in a user editable file and not bloat the library itself ...
> 

I had the idea that some codecs would need to override default
AVOptions, more specifically min and max ranges, like libx264 or dnxhd
for qmin/qmax.

For example DNxHD supports qmax up to 1024, and FFmpeg cannot use this
possibility atm (needed to encode /dev/random for example), should I add
bump qmax max value to 1024 ?

We might add a mechanism where codecs could override ranges and default
value.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA