[FFmpeg-devel] [PATCH] Seeking and resync support in nuv demuxer

[Michael Niedermayer]

On Sat, Jun 07, 2008 at 07:40:18PM +0200, Reimar D?ffinger wrote:
> On Sat, Jun 07, 2008 at 03:22:44PM +0200, elupus wrote:
[...]
> > +                // TODO - add general support in av_gen_search, so it adds positions after reading timestamps
> 
> I have the feeling there is a very good reason why this is not done.
> At least that it leads to a very partial index seems "dangerous" to me.

partial indexes are fine, the stuff was designed with that in mind ...
The only issue is that inserts can be O(n) but then one needs a really
large index and has to seek around funnily for this to matter. Also by
simply switching indexes to avtree that problem would disapear ...


> 
> > +                av_add_index_entry(s->streams[frametype == NUV_VIDEO ? ctx->v_id : ctx->a_id]
> > +                                 , pos, dts, size + HDRSIZE, 0, hdr[2] == 0 ? AVINDEX_KEYFRAME : 0);
> 
> And either way I really think this should not be done here at least.

That one should be fine, other demuxers do it as well


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080607/8633682c/attachment.pgp>