[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

[Luca Abeni]

Hi Michael,

Michael Niedermayer wrote:
[...]
>>> Besides a packet could be passed to more than 1 muxer and thus its content
>>> must not be changed by any muxer.
>> Ok; I tried to fix this bug, but I do not know if the attached patch
>> is the best solution. It seems to work well here.
> 
> Iam not sure if its the best either ... maybe we should change
> ff_avc_parse_nal_units to take a ByteIOContext ...
> Of course only if it would end up simpler, if its not simpler than
> your patch here is ok

Ok; this afternoon I'll try to have a look at passing a ByteIOContext as an
argument (but first I have to understand why this can simplify things ;-).

BTW, you said that you also found other muxers with the same problem...
Can you post the list of such muxers (or the grep command you used)
somewhere? (in a roundup issue, or something)
In this way, the information does not get lost, and people searching for
some way to help can find a list of issues to fix.


				Thanks,
					Luca