[FFmpeg-devel] One memory leakage in AAC/AC3 parser in ffmpeg

David LIU david.liu
Thu Jun 19 09:34:00 CEST 2008


From: ffmpeg-devel-bounces at mplayerhq.hu
[mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
Sent: Thursday, June 19, 2008 12:30 AM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] One memory leakage in AAC/AC3 parser in ffmpeg

On Wed, Jun 18, 2008 at 11:58:02AM +0200, David LIU wrote:
>> Hi,
>> 
>> Please review patch and let me know reject or accept
>> 
>> Best regards

[...]

>> (Also avoid top-posting.)
   ^^^^^^^^^^^^^^^^^^^^^^^

>besides that, ff_parse_close() should be used not a new redundant function
added.

[David]: There is ParseContext type in ff_parse_close(). I have to use
AACAC3ParseContext type and that's why I create new ff_parse_close2().

And I believe my fix is correct and I tested. The result is correct.

>-- 
>Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

>I hate to see young programmers poisoned by the kind of thinking Ulrich
Drepper puts forward since it is simply too narrow -- Roman Shaposhnik





More information about the ffmpeg-devel mailing list