[FFmpeg-devel] [PATCH] mp3 in oma support

[Michael Niedermayer]

On Mon, Jun 23, 2008 at 09:36:12AM +0200, Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> > On Sun, Jun 22, 2008 at 10:54:44PM +0200, Benjamin Larsson wrote:
[...]
> > [...]
> >   
> >> +        case OMA_CODECID_MP3:
> >> +	    {
> >> +            uint32_t header;
> >> +
> >> +            url_fseek(s->pb, EA3_pos + EA3_HEADER_SIZE, SEEK_SET);
> >> +            ret = get_buffer(s->pb, buf, 4);
> >> +            header = AV_RB32(buf);
> >> +            framesize = ff_mpa_decode_header(st->codec,header,&samplerate);
> >> +            if(framesize==-1) {
> >> +                av_log(s, AV_LOG_ERROR, "Valid MP3 header not found!\n");
> >> +                return -1;
> >> +            }
> >> +            st->need_parsing = AVSTREAM_PARSE_FULL;
> >> +            break;
> >> +        }
> >>     
> >
> > except need_parsing this looks unneeded
> >
> >   
> ff_mpa_decode_header fills in the bit_rate, sample_rate and amount of channels. Without that it wont play.

neither raw mp3 nor mpeg-ps/ts demuxers fill them, so the problem is elsewhere

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080623/52c84878/attachment.pgp>