[FFmpeg-devel] [PATCH] dct-test compile fix

[Måns Rullgård]

Ronald S. Bultje wrote:
> Hi,
>
> most recent svn fails to compile dct-test for me:
>
> In file included from dct-test.c:35:
> dsputil.h: In function 'copy_block2':
> dsputil.h:696: warning: implicit declaration of function 'AV_WN16'
> dsputil.h:696: warning: implicit declaration of function 'AV_RN16'
> dsputil.h: In function 'copy_block4':
> dsputil.h:707: warning: implicit declaration of function 'AV_WN32'
> dsputil.h:707: warning: implicit declaration of function 'AV_RN32'
> dct-test.c: In function 'main':
> dct-test.c:537: error: 'mm_flags' undeclared (first use in this function)
> dct-test.c:537: error: (Each undeclared identifier is reported only once
> dct-test.c:537: error: for each function it appears in.)
>
> There's two problems manifested here. First, avutil.h does not include
> intreadwrite.h, where the AV_[RW]N{16,32} macros are defined.

Are these macros used in avutil.h?  If not, avutil.h should not
include intreadwrite.h.  More likely, dsputil.h should be including
intreadwrite.h, since it appears to be using things from it.

> The
> second problem is that mm_flags is conditionally defined in dsputil if
> HAVE_MMX is defined, but dct-test.c does not include config.h and thus
> it is never defined.

This area is a mess.  It was obviously written with only x86 in mind.
A general cleanup would be welcome.

-- 
M?ns Rullg?rd
mans at mansr.com