[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding

[Vladimir Voroshilov]

2008/6/18 Diego Biurrun <diego at biurrun.de>:
> On Wed, Jun 18, 2008 at 03:45:43AM +0200, Michael Niedermayer wrote:
>> On Fri, Jun 13, 2008 at 06:41:40PM +0700, Vladimir Voroshilov wrote:
>> > 2008/6/12 Michael Niedermayer <michaelni at gmx.at>:
>> > > On Thu, Jun 12, 2008 at 12:20:14AM +0700, Vladimir Voroshilov wrote:
>> [...]
>> > >> + *
>> > >> + * Pitch delay is coded:
>> > >
>> > > is it pitch delay or pitch lag? you mix the terms randomly ...
>> >
>> > Hm. i thought "lag" is synonym for "delay" (as my dictionary says).
>> > Specification uses "delay" in most of text, while reference
>> > code uses "lag" everywhere.
>> > Tell me if i should replace all instances with "lag" or "delay" only
>> > (if so, tell also what is better and why, please)
>>
>> ask diego, he is the master of english consistency.
>> Iam not a native english speaker and do not really know the difference
>> (if there is any) between lag and delay.
>
> TTBOMK both are synonyms.  I would prefer delay, which is the more
> common and more technical term and AFAICT it is used everywhere else.
> Go for delay.

Done.
I didn't touch filename, though.
"acelp_pitch_delay" sounds too long for me
If you wish and there are no more fixes in the file i can rename it too.

I've also tried to fix short comment for ff_acelp_past_gain* routines,
not sure that it is enough good.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_acelp_lag63.diff
Type: text/x-diff
Size: 12330 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080624/c0d116b8/attachment.diff>