[FFmpeg-devel] [PATCH] Make ffserver print each launched commandline just before to launch them

[Baptiste Coudurier]

Hi,

Stefano Sabatini wrote:
> On date Monday 2008-06-23 14:15:27 -0700, Baptiste Coudurier encoded:
>> Hi,
>>
>> Stefano Sabatini wrote:
>>> Hi all,
>>> currently ffserver in debug-mode prints the launched commandlines just
>>> when parsing the configuration file.
>>>
>>> This way, if the user enables no-launch mode the launching commandline
>>> messages are issued but the commandlines are indeed not launched, which
>>> is misleading.
>> Might print a message saying that launch has been disabled.
> 
> What about to print a message with http_log() at the begin of
> start_children?

Why not.

>>> The attached patch fixes the problem, simply moving the code which
>>> prints the commandline in the start_children() function.
>>>
>>> Note that the code which computes the pathname is moved before the
>>> code which closes all the file descriptors (including that for the
>>> logfile).
>>>
>>> Also this patch makes the launched commandlines be printed by
>>> http_log() (ergo on stderr) rather than on stderr, as this seems to me
>>> the correct behaviour, let me know if you prefer this fix into a
>>> separate patch.
>> Separate commits for sure, and yes as soon as logfile is setup use http_log.
> 
> First patch attached, if it is OK I'll apply also the second which
> changes fprintf(stdout, ...) to http_log(...).
> 

Patch looks ok.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA