[FFmpeg-devel] [Patch] Fix for static leaks in h264.c

[Art Clarke]

On Wed, Jun 25, 2008 at 9:01 AM, M?ns Rullg?rd <mans at mansr.com> wrote:

>
> Michael Niedermayer wrote:
> > On Tue, Jun 24, 2008 at 08:34:34PM -0400, Art Clarke wrote:
> >> This is a continuation of the patch for leaks as in:
> >> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-June/048859.html
> >>
> >> Same test case applies; this time though pass in a test file that
> requires
> >> the h263 decoder.  This one is slightly hairier than h263.c because I
> had to
> >> unroll some loops to get sufficient space in the data segment.  Yes, it
> >> makes me feel squeamish to look at it too.
> >
> > Maybe init_vlc( ..., INIT_VLC_USE_NEW_STATIC) could be used in a loop
> with
> > a table of the sizes
>
> That doesn't work.  The size of static arrays must be an integer constant
> expression.  Such an expression can, by definition, not vary in a loop.
>
> --
> M?ns Rullg?rd
> mans at mansr.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel


Agree with both of you, but Michael does point the way to a more elegant
solution I think.

Attempt #2.

- Art
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_static_leaks2.patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080625/bc5a3128/attachment.txt>