[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Wed, Jun 25, 2008 at 04:18:54PM +0200, Reinhard Tartler wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>>> My objection is that it bloats the lib, causes us work, does not move
>>> ffmpeg forward and may lead to all kinds of obscure bugs. The code has
>>> not been designed with the consideration that both scalers might be enabled
>>> at the same time.
>> Do you *know* about breakage or is this pure speculation?
> 
> speculation
> And i do not like code in svn that iam unsure of if it is correct. Especially
> if i have noone who is willing to maintain the code.
> 
> 
>>> If we drop the old API everyone is forced to switch to the new one.
>> Except that some downstreams don't. In debian we collect packages that
>> break beacuse of this here:
>>
>> http://bugs.debian.org/cgi-bin/pkgreport.cgi?users=pkg-multimedia-maintainers at lists.alioth.debian.org&tag=img-convert
>>
>> Patches are welcome of course. If you know about more packages affected
>> by this issue, please tag them accordingly (or notify me to do that).
>>
> 
>>> -> so this patch is strictly more work for us as well as everyone at average
>>>    than droping the old API.
>> Distros like Mandriva, Debian, Ubuntu etc have to do this additional
>> work then. Which is unfortunate because package maintainers do not have
>> the knowledge to properly maintain that patch.
> 
> I can understand that distros do not like to maintain the patch, but I
> do neither want to maintain it!
> So what was it that you wanted?
> You want one of us to maintain your patch which is too much work for you to
> do?

IMHO removing 2 lines is not much work, Im also lazy about this and I
just removed:

-#ifndef CONFIG_SWSCALE
+//#ifndef CONFIG_SWSCALE

-#endif
+//#endif

And I have access to the old API.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA