[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding
Michael Niedermayer
michaelni
Sat Jun 28 19:40:18 CEST 2008
On Sat, Jun 28, 2008 at 08:09:38AM +0700, Vladimir Voroshilov wrote:
> 2008/6/28 Michael Niedermayer <michaelni at gmx.at>:
> > On Fri, Jun 27, 2008 at 09:59:49PM +0700, Vladimir Voroshilov wrote:
>
> [...]
>
> >> I have question about rounding. What is better:
> >> (a >> 13)<<10
> >> or
> >> (a>>3) & ~0x3ff
> >> ?
> >> Such code is required for bitexactness.
> >
> >
> > i prefer the &~ variant
>
> Here is it.
looks ok
About the rest of the g729 code, will you split out furter parts?
Or should i review it as it is?
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080628/125667af/attachment.pgp>
More information about the ffmpeg-devel
mailing list